Skip to content

std: return Elf object from constructors instead of filling in pointer #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2019
Merged

std: return Elf object from constructors instead of filling in pointer #2998

merged 2 commits into from
Aug 4, 2019

Conversation

daurnimator
Copy link
Contributor

No description provided.

@daurnimator daurnimator added the standard library This issue involves writing Zig code for the standard library. label Aug 3, 2019
@andrewrk
Copy link
Member

andrewrk commented Aug 3, 2019

The thing preventing this change before was prealloc_file and auto_close_stream (and not having #2761 and #2765 done). Looking now, it seems those fields are no longer used, and there is some dead code. This PR should remove those fields and delete the dead code.

@daurnimator
Copy link
Contributor Author

Done.

@andrewrk andrewrk merged commit f01cb8c into ziglang:master Aug 4, 2019
@daurnimator daurnimator deleted the return-elf branch August 4, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daurnimator @andrewrk