Support sentinel in @Type #3814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
approved these changes
Dec 1, 2019
marler8997
force-pushed
the
sentinelInType
branch
5 times, most recently
from
26bbdd9 to
7d85c14
Compare
marler8997
commented
Dec 2, 2019
src/ir.cpp
Outdated
| static Error get_const_field_sentinel(IrAnalyze *ira, IrInstruction *source_instr, ZigValue *struct_value, | ||
| const char *name, size_t field_index, ZigType *elem_type, ZigValue **result) | ||
| static Error get_const_field_sentinel(IrAnalyze *ira, ZigValue *struct_value, const char *name, size_t field_index, | ||
| IrInstruction *source_instr, ZigType *elem_type, ZigValue **result) | ||
| { | ||
| ZigValue *field_val = get_const_field(ira, struct_value, name, field_index); |
There was a problem hiding this comment.
This function is not correct, going to wait for #3787 which has the fix.
marler8997
force-pushed
the
sentinelInType
branch
from
00885c3 to
7990152
Compare
marler8997
force-pushed
the
sentinelInType
branch
from
7990152 to
54c0657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3816