Translate-c-2 enums #3908
Translate-c-2 enums #3908
Conversation
| \\ p, | ||
| \\}; | ||
| , &[_][]const u8{ | ||
| \\pub const a = enum_unnamed_1.a; |
There was a problem hiding this comment.
These could be made to match C even bettee by using @enumToInt
There was a problem hiding this comment.
@andrewrk since integer operations on extern enums didn't (understandably) get accepted, could we do this instead?
Using enums as flags might be abuse of the type system but it is still a common thing. This would cut out all the @enumToInt conversions but you would still get the awkwardness of abusing the type system with @intToEnum.
There was a problem hiding this comment.
I think it could make sense to translate the non-namespaced enum values as integers rather than the enum values (is that what you are proposing?). Then people have the choice of using enum literals (or fully qualified enum values) to get the enum type, or the non-namespaced values to get the integer.
The downside would be that using the integer types would not coerce to the enum type if, for example, it was used as a function parameter type.
I'm definitely open to considering this but I don't think the choice is clear. Would you mind opening a separate proposal for this?
Currently this implementation works different from stage 1 in hopes that #2115 (comment) is accepted.
For specifics see the test I added.