Skip to content

Improve extern enum #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve extern enum #3909

wants to merge 1 commit into from

Conversation

Vexu
Copy link
Member

@Vexu Vexu commented Dec 15, 2019

  • Multiple same values allowed.
  • Non-exhaustive: else prong always needed in switch.
  • @intToEnum can't fail.

Closes #2115

andrewrk
andrewrk approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@andrewrk
Copy link
Member

Landed in 0f38410

@andrewrk andrewrk closed this Dec 16, 2019
@daurnimator daurnimator mentioned this pull request Dec 16, 2019
Closed
@Vexu Vexu deleted the improve-extern-enum branch December 18, 2019 22:04
Mouvedia referenced this pull request in ducdetronquito/http Nov 15, 2020
@ducdetronquito
✨ Add a Response builder.
5bb3acc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enums should disallow multiple enumerations with the same value
2 participants
@Vexu @andrewrk