Payload captures no longer alias the original value #4454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The payload doesn't alias anymore the same memory it comes from and is instead a fresh copy of the original object.
|
Curious -- Do you know if LLVM only emits a copy in Release build modes when the capture was modified? |
|
Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad discussed with Andrew in #4443 I've changed the behavior of
for/if/while/switchso that a "simple" capture (|v|) always creates a copy of the payload in a scope-local variable. If you need to modify the underlying memory just use a "ref" capture (|*v|).I've added a few tests to make sure this new behavior is respected and I've run the stage1/std test suite and I've not spotted any regression. That's possibly a sign of how nobody expected the capture to behave like it did :P or maybe everybody knew that and worked around it.
Closes #4361
Closes #2915