-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
complete out the os.sched_getaffinity error set #6886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1623328
dev
komuw 41517b8
dev
komuw 60e4d57
dev
komuw 98839f8
dev
komuw 7e09ba4
dev
komuw bc03e53
dev
komuw b05efec
dev
komuw 4f28183
dev
komuw 458e944
dev
komuw ff06ce9
dev
komuw 5ddcd2b
dev
komuw a046564
complete out the getaffinity error set
komuw 4a8e186
add doc string for sched_getaffinity
komuw 812d14f
add test for os.sched_getaffinity
komuw 58836e3
rm local development files
komuw 8835be0
add missing errors to CpuCountError and also zig fmt lib/std/thread.zig
komuw f1b6c19
skip test of os.sched_getaffinity in non-linux OSes
komuw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My assumption here is that we will never have as many threads as
maxInt(i32)
when running tests.But there is a good probability that I'm wrong. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On windows and Osx, this is failing with
Should I restrict this test to linux only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the world of cross-platform non-posix abstractions (and yet another opportunity to plug #6600):
pthread_setaffinity_np
/pthread_getaffinity_np
cpuset_getaffinity
/cpuset_setaffinity
thread_policy_get
/thread_policy_set
let you get/set the affinity tag for a given thread but that's itThat's a pretty safe assumption (why are PIDs signed???), spawning that many threads requires an ungodly amount of memory heh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have skipped the test for non-linux OSes. I have also opened #6907 to implement
sched_getaffinity
for other OSes. I'll attempt to do that in a follow up PR, if no one else will have done so already.