Skip to content

sparc64 has a 8Kb page size #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

sparc64 has a 8Kb page size #6960

merged 1 commit into from
Nov 3, 2020

Conversation

jedisct1
Copy link
Contributor

@jedisct1 jedisct1 commented Nov 3, 2020

Since support for sparc64 was recently added: use the correct page size for this architecture.

daurnimator
daurnimator approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@daurnimator daurnimator left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also https://github.com/ziglang/zig/pull/3815/files#diff-9cb4e420bd04558390c4814235489594d387d391c8223c4ca1468ab12940d479R11-R16

edit: uh, that link doesn't seem to work. https://github.com/daurnimator/zig/blob/9ce8488bf961050670de4da4cb3da6ede0ab25d9/lib/std/mem.zig#L12-L18

@andrewrk
Copy link
Member

andrewrk commented Nov 3, 2020

@daurnimator I don't know where we last landed with regards to page size but your min_page_size / max_page_size patch looks good to me

@andrewrk andrewrk merged commit 342ba96 into ziglang:master Nov 3, 2020
@daurnimator
Copy link
Contributor

@daurnimator I don't know where we last landed with regards to page size but your min_page_size / max_page_size patch looks good to me

You closed the PR and created #4082

@jedisct1 jedisct1 deleted the sparc64-pagesize branch November 3, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daurnimator daurnimator daurnimator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jedisct1 @andrewrk @daurnimator