stage1: Fix undefined assignment for bitfields #7081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents silent memory corruption. Closes ziglang#7055
daurnimator
reviewed
Nov 12, 2020
| // This is a pointer into a packed struct, we can't use memset here. | ||
| // The jury is still out on what pattern should be written here so clear the | ||
| // old value and call it a day. Generating a 0xAA...AA mask for this n-bit | ||
| // value is left as an exercise for the (bored) reader. |
There was a problem hiding this comment.
Could you include the string TODO: so that it can be grepped for later? Possibly referencing an open zig issue.
There was a problem hiding this comment.
Not really, the original bug was brushed off as something not meant to be fixed in stage1.
The fix is barely enough to avoid some gratuitous memory corruption.
|
cherry-picked into 0.7.x => c6c25a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents silent memory corruption.
Closes #7055