stage1 and stage2: closes #7120 #7122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnask
added
the
stage1
LemonBoy
reviewed
Nov 16, 2020
| @@ -29544,6 +29544,23 @@ static IrInstGen *ir_analyze_instruction_check_switch_prongs(IrAnalyze *ira, | |||
| } | |||
| } | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Suggested change
| } else { | |
| } else if (!type_is_global_error_set(switch_type)) { |
You can save a whole indentation level.
| } else { | ||
| if (!type_is_global_error_set(switch_type)) { | ||
| bool needs_else = false; | ||
| for (uint32_t i = 0; i < switch_type->data.error_set.err_count; i += 1) { |
There was a problem hiding this comment.
Isn't this a more expensive version of const bool needs_else = instruction->range_count != switch_type->data.error_set.err_count ?
By the time you reach this line the compiler already knows all the values are correctly typed and the prong list contains no duplicates.
|
|
||
| AstNode *prev_node = field_prev_uses[err_entry->value]; | ||
| if (prev_node == nullptr) { | ||
| needs_else = true; |
There was a problem hiding this comment.
Anyway, the indentation is off and you can exit with a break once this becomes true.
|
Thanks. I think I am going to close this pr as #5693 is already trying to handle it and also vexu said that it was intentional #7120 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where
was allowed. Funnily, the stdlib and some parts of stage2 included this pattern, so I fixed it there too.
My editor does weird stuff with whitespace, so feel free to ignore that.
See here for conversation on irc.