translate-c: Implement flexible arrays #8891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This was blocking me, so I was just about to ask in the issue if I could take a crack at it if no one else was planning to. I will try this out later today. |
Vexu
approved these changes
Jun 10, 2021
ehaas
force-pushed
the
translate-c-flexible-arrays
branch
from
fd03c02 to
4a7df9c
Compare
ehaas
commented
Jun 10, 2021
|
|
||
| const field_index = field_decl.getFieldIndex(); | ||
| const bit_offset = layout.getFieldOffset(field_index); // this is a target-specific constant based on the struct layout | ||
| const byte_offset = bit_offset / 8; |
There was a problem hiding this comment.
This division assumes 8 bits per byte; is it worth using toCharUnitsFromBits to ensure it works on exotic platforms with different-sized bytes?
There was a problem hiding this comment.
I highly doubt this will ever become an issue.
There was a problem hiding this comment.
Yep, zig still hasn't decided to support non-octet bytes
#7693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8759