Skip to content

Rename @byteOffsetOf to @offsetOf #9073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2021
Merged

Rename @byteOffsetOf to @offsetOf #9073

merged 2 commits into from
Jun 12, 2021

Conversation

Exonorid
Copy link
Contributor

This pull request renames the @byteOffsetOf built-in function in order to be more consistent with the other built-in functions, resolving issue #7794.

Vexu
Vexu approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@Vexu Vexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could easily make zig fmt update code for this automatically. There should be plenty of examples of it in the code if you want to try doing it.

@Vexu Vexu linked an issue Jun 12, 2021 that may be closed by this pull request
Proposal: @offsetOf instead of @byteOffsetOf #7794
Closed
@Vexu Vexu force-pushed the rename_offsetOf branch from b3e34c4 to 6fc47f6 Compare June 12, 2021 08:15
@Vexu Vexu force-pushed the rename_offsetOf branch from 6fc47f6 to b2a3e7c Compare June 12, 2021 10:01
@Vexu Vexu merged commit 0d022eb into ziglang:master Jun 12, 2021
@Exonorid Exonorid deleted the rename_offsetOf branch August 5, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vexu Vexu Vexu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: @offsetOf instead of @byteOffsetOf
2 participants
@Exonorid @Vexu