Skip to content

Fail adapter migration if the IEEE cannot be written #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Apr 15, 2025

Logging a warning but still not writing the IEEE address isn't a good default, since the resulting network superficially functions but then slowly degrades as network management commands using the wrong IEEE will not work.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (1f61e0b) to head (da852de).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #672      +/-   ##
==========================================
+ Coverage   99.21%   99.43%   +0.21%     
==========================================
  Files          51       51              
  Lines        3691     3693       +2     
==========================================
+ Hits         3662     3672      +10     
+ Misses         29       21       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit ce8a126 into zigpy:dev Apr 27, 2025
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants