Replace Appveyor by GitHub Actions for Windows #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaminijha1
force-pushed
the
workflow_on_window
branch
from
abd3e18 to
2785aa1
Compare
shubham-padia
suggested changes
Jun 18, 2025
There was a problem hiding this comment.
Sorry for the delay. Overall looks good, requested some changes. @yaminijha1 let me know if you will be interested to make those changes or not. If not, I can make those changes and add you as a co-author.
.github/workflows/node.js.yml
Outdated
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "17" |
There was a problem hiding this comment.
Can you change this to lts/*, so we get the latest node version.
.github/workflows/node.js.yml
Outdated
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3 |
There was a problem hiding this comment.
We should use setup-node@v4 since that's the latest version
|
@yaminijha1 Can you squash the second commit into the first? Thanks! |
Fixes zulip#1070 This commit replaces Appveyor with a GitHub Actions workflow for Windows. It uses `setup-node@v4` with `node-version: lts/*` and `checkout@v4`. Also removes `appveyor.yml`.
yaminijha1
force-pushed
the
workflow_on_window
branch
from
ab20f3c to
ff1125b
Compare
|
@timabbott this should be ready for integration review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes #1070
This PR remove the Appveyor CI workflow and adds GitHub Actions on Windows build