settings: Always show the sidebar in case of settings page.

[shubham-padia]

Fixes #1077.
Users were getting stuck in the settings page, unable to click on an organisation tab to go back. Enabling the sidebar for settings page in all cases will help ensure that the users can navigate back when needed.

Screenshots and screen captures:

Platforms this PR was tested on:

• Windows
• macOS
• Linux (specify distro)

Self-review checklist

• Self-reviewed the changes for clarity and maintainability
  (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

• Explains differences from previous plans (e.g., issue description).
• Highlights technical choices and bugs encountered.
• Calls out remaining decisions and concerns.
• Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

• Each commit is a coherent idea.
• Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

• Visual appearance of the changes.
• Responsiveness and internationalization.
• Strings and tooltips.
• End-to-end functionality of buttons, interactions and flows.
• Corner cases, error conditions, and easily imagined bugs.

[timabbott]

So it appears this is changing the behavior to now write to the settings (the default of whether to show the sidebar on startup) when toggling the sidebar manually. I don't think that's what we were looking to do?

[shubham-padia]

I'm not sure if that is the case i.e. the default of whether to show the sidebar is changed by setConfigItem.

From my understanding, it does not override any global config if override is not set to true, which it is not in that case.

[timabbott]

I'm still confused. Previously, this function, which is called from multiple code paths, did not call setConfigItem . Now it does. This to me seems like a behavior change that is not part of "Always showing the sidebar in case of settings page".

If this is fixing another issue that you noticed while working on this PR, maybe it should be its own commit.

But to me it looks like it is introducing a bug. I think previously, the behavior was we have a setting for whether the sidebar is hidden in general in the configuration that you access via the settings panel, and also there's a quick way to toggle it without changing what happens on next startup. This seems to make clicking the quick toggle always change it on next startup.

I don't really understand the purpose of adding that setConfigItem here at all, but that's my understanding of what impacts it has.