Skip to content

autocomplete: Introduce topic input autocomplete #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions lib/api/route/channels.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import 'package:json_annotation/json_annotation.dart';

import '../core.dart';
part 'channels.g.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits in commit message:

autocomplete: Setup stream topics API binding

See previous commits touching lib/api/route/ for examples for the summary line.

Also "setup" is a noun but not a verb; "set up" is the verb. (Similarly "log in".)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this is a lot closer:

api: Set up stream topics API binding

Let's specifically match previous commits that added new endpoint bindings, though. Here's a command that shows those (as well as a few other matches):
$ git log --oneline lib/api/route | grep -vw nfc

So in particular
6d9f22d api: Add markAllAsRead, markStreamAsRead, and markTopicAsRead routes
dfcc6ca api: Add updateMessageFlags and updateMessageFlagsForNarrow routes
b8290cd api: Add routes registerFcmToken, registerApnsToken

For this, let's then say "api: Add route getStreamTopics".


/// https://zulip.com/api/get-stream-topics
Future<GetStreamTopicsResult> getStreamTopics(ApiConnection connection, {
required int streamId,
}) {
return connection.get('getStreamTopics', GetStreamTopicsResult.fromJson, 'users/me/$streamId/topics', {});
}

@JsonSerializable(fieldRename: FieldRename.snake)
class GetStreamTopicsResult {
final List<GetStreamTopicsEntry> topics;

GetStreamTopicsResult({
required this.topics,
});

factory GetStreamTopicsResult.fromJson(Map<String, dynamic> json) =>
_$GetStreamTopicsResultFromJson(json);

Map<String, dynamic> toJson() => _$GetStreamTopicsResultToJson(this);
}

@JsonSerializable(fieldRename: FieldRename.snake)
class GetStreamTopicsEntry {
final int maxId;
final String name;

GetStreamTopicsEntry({
required this.maxId,
required this.name,
});

factory GetStreamTopicsEntry.fromJson(Map<String, dynamic> json) => _$GetStreamTopicsEntryFromJson(json);

Map<String, dynamic> toJson() => _$GetStreamTopicsEntryToJson(this);
}
37 changes: 37 additions & 0 deletions lib/api/route/channels.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading