-
Notifications
You must be signed in to change notification settings - Fork 308
autocomplete: Introduce topic input autocomplete #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ababf79
autocomplete [nfc]: Rename Autocomplete to ComposeContentAutocomplete
Khader-1 0ce17ad
autocomplete [nfc]: Factor out generic AutocompleteView
Khader-1 fad368c
autocomplete [nfc]: Factor out generic AutocompleteField
Khader-1 50a7609
api: Add route getStreamTopics
Khader-1 046ceab
autocomplete: Add autocomplete for topic to send to
Khader-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import 'package:json_annotation/json_annotation.dart'; | ||
|
||
import '../core.dart'; | ||
part 'channels.g.dart'; | ||
|
||
/// https://zulip.com/api/get-stream-topics | ||
Future<GetStreamTopicsResult> getStreamTopics(ApiConnection connection, { | ||
required int streamId, | ||
}) { | ||
return connection.get('getStreamTopics', GetStreamTopicsResult.fromJson, 'users/me/$streamId/topics', {}); | ||
} | ||
|
||
@JsonSerializable(fieldRename: FieldRename.snake) | ||
class GetStreamTopicsResult { | ||
final List<GetStreamTopicsEntry> topics; | ||
|
||
GetStreamTopicsResult({ | ||
required this.topics, | ||
}); | ||
|
||
factory GetStreamTopicsResult.fromJson(Map<String, dynamic> json) => | ||
_$GetStreamTopicsResultFromJson(json); | ||
|
||
Map<String, dynamic> toJson() => _$GetStreamTopicsResultToJson(this); | ||
} | ||
|
||
@JsonSerializable(fieldRename: FieldRename.snake) | ||
class GetStreamTopicsEntry { | ||
final int maxId; | ||
final String name; | ||
|
||
GetStreamTopicsEntry({ | ||
required this.maxId, | ||
required this.name, | ||
}); | ||
|
||
factory GetStreamTopicsEntry.fromJson(Map<String, dynamic> json) => _$GetStreamTopicsEntryFromJson(json); | ||
|
||
Map<String, dynamic> toJson() => _$GetStreamTopicsEntryToJson(this); | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits in commit message:
See previous commits touching lib/api/route/ for examples for the summary line.
Also "setup" is a noun but not a verb; "set up" is the verb. (Similarly "log in".)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this is a lot closer:
Let's specifically match previous commits that added new endpoint bindings, though. Here's a command that shows those (as well as a few other matches):
$ git log --oneline lib/api/route | grep -vw nfc
So in particular
6d9f22d api: Add markAllAsRead, markStreamAsRead, and markTopicAsRead routes
dfcc6ca api: Add updateMessageFlags and updateMessageFlagsForNarrow routes
b8290cd api: Add routes registerFcmToken, registerApnsToken
For this, let's then say "api: Add route getStreamTopics".