adjust selection after replaceall
#3623
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias314
force-pushed
the
m3/replace-selection
branch
from
6b5805c to
5a8d691
Compare
dmaluka
approved these changes
Mar 9, 2025
|
I made this a draft some time ago because I've been wondering if this is the right approach. Cursor positions and selections are automatically adjusted when inserting or deleting text. This is done in |
|
Yeah, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
replaceall, selections are preserved. Currently they are left untouched even if the boundaries have shifted as a result of the replacement. This PR adjusts the beginning or end of a selection according to the number of characters added or deleted in the last line of the selection.