Skip to content

add "create path" operation (files only for now) to Azure Storage data_lake (using Pipeline architecture) #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Oct 26, 2021

Conversation

thovoll
Copy link
Contributor

@thovoll thovoll commented Sep 4, 2021

This adds create_path operation (files only for now) to the data_lake crate using the pipeline architecture and adds examples.

Issue #356

@thovoll
Copy link
Contributor Author

thovoll commented Sep 4, 2021

Doesn't compile yet

@thovoll
Copy link
Contributor Author

thovoll commented Sep 28, 2021

Will add integration tests separately: #372

@thovoll thovoll marked this pull request as ready for review October 4, 2021 15:32
@thovoll
Copy link
Contributor Author

thovoll commented Oct 4, 2021

e2e test works now, manually validated with the following environment variables set to valid values:
AZURE_TENANT_ID
AZURE_CLIENT_ID
AZURE_CLIENT_SECRET
ADSL_STORAGE_ACCOUNT
ADSL_STORAGE_MASTER_KEY (for operations other than 'create path')
Command: cargo test --features test_e2e -p azure_storage --test data_lake -- --nocapture

The DefaultCredential ends up using EnvironmentCredential which ends up using ClientSecretCredential.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry for not getting a review on this sooner - we've been focused on cosmos. I'd like to try to adopt the mock testing framework as I noted in one of the comments before we merge this.

@thovoll thovoll requested a review from rylev October 25, 2021 14:22
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥ Thanks for taking the time to work on this! There are some nits I found in the review, but nothing blocking. I'm going to merge this, and we can address the nits in a follow up.

@rylev rylev merged commit ec9cc59 into Azure:main Oct 26, 2021
@thovoll thovoll deleted the data_lake/create_path branch October 26, 2021 14:04
@thovoll
Copy link
Contributor Author

thovoll commented Oct 26, 2021

Thanks @rylev! New branch here, will raise PR later: https://github.com/thovoll/azure-sdk-for-rust/commits/data_lake/create_path_2

@thovoll
Copy link
Contributor Author

thovoll commented Nov 4, 2021

Follow-up PRs: #451 and #491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Lake Data Lake Storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants