-
Notifications
You must be signed in to change notification settings - Fork 283
add "create path" operation (files only for now) to Azure Storage data_lake (using Pipeline architecture) #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doesn't compile yet |
…ables. Fix newlines. Don't panic when create path fails.
Will add integration tests separately: #372 |
e2e test works now, manually validated with the following environment variables set to valid values: The DefaultCredential ends up using EnvironmentCredential which ends up using ClientSecretCredential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Sorry for not getting a review on this sooner - we've been focused on cosmos. I'd like to try to adopt the mock testing framework as I noted in one of the comments before we merge this.
…til all operations are using pipeline architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
♥ Thanks for taking the time to work on this! There are some nits I found in the review, but nothing blocking. I'm going to merge this, and we can address the nits in a follow up.
Thanks @rylev! New branch here, will raise PR later: https://github.com/thovoll/azure-sdk-for-rust/commits/data_lake/create_path_2 |
This adds create_path operation (files only for now) to the data_lake crate using the pipeline architecture and adds examples.
Issue #356