Remove traits AsDataLakeClient and AsFileSystemClient #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. Matches CosmosClient in that it doesn't use Arc anymore. Still uses Arc e.g. in StorageAccountClient.new_emulator which should probably be removed as well. e2e test passes.
|
@rylev this is the follow-up I promised in #358 and as discussed yesterday. I tried keeping this first commit as small as possible but I did include removing the use of Arc to match the CosmosDB crate. I'm new to Arc so particularly interested in feedback there; I should probably remove Arc from data_lake clients more broadly. The e2e test passes with this commit. |
thovoll
force-pushed
the
data_lake/remove_traits
branch
from
62be49f to
6e8a774
Compare
…to_data_lake_client and into_file_system_client functions. Matches CosmosClient in that it doesn't use Arc and doesn't return Errors anymore. e2e test passes.
… function. Matches CosmosClient in that it doesn't use Arc anymore. Still uses Arc e.g. in StorageAccountClient.new_emulator which should probably be removed as well. e2e test passes." This reverts commit d252f98
… can no longer create a DataLakeClient and callers must use DataLakeClient.new() instead.
thovoll
changed the title
|
I attempted to remove AsStorageClient but this impacts areas I don't want to change in this PR, e.g. queue. Reverted those changes and limiting PR to data_lake only. |
thovoll
changed the title
thovoll
changed the title
thovoll
commented
Nov 5, 2021
thovoll
commented
Nov 5, 2021
thovoll
commented
Nov 5, 2021
thovoll
commented
Nov 5, 2021
thovoll
commented
Nov 5, 2021
thovoll
commented
Nov 5, 2021
rylev
suggested changes
Nov 5, 2021
This was referenced Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up that came out of #358.