Skip to content

add HttpClientArc & TokenCredentialArc #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ctaggart
Copy link
Contributor

This is to support http connection pooling #78. Using an Arc was recommended by @rylev in ctaggart/autorust#86 (comment) to avoid lifetimes and it works. 🥳 This should work fine with an HttpClient interface once we have one, started by @MindFlavor in #79. The code generation changes are in ctaggart/autorust#86 to make this work for mgmt services.

@ctaggart ctaggart requested review from rylev and MindFlavor November 12, 2020 17:45
@ctaggart ctaggart changed the title add HttpClientArc & TokenCredentialArc add HttpClientArc & set user-agent Nov 13, 2020
@ctaggart ctaggart changed the title add HttpClientArc & set user-agent add HttpClientArc & TokenCredentialArc Nov 13, 2020
@ctaggart
Copy link
Contributor Author

These changes are included in #81.

@ctaggart ctaggart closed this Nov 13, 2020
@ctaggart ctaggart deleted the http_pool branch June 15, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant