add HttpClientArc & set user-agent #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Nov 13, 2020
| use std::sync::Arc; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct HttpClientArc(Arc<reqwest::Client>); |
There was a problem hiding this comment.
I'm not sure if we gain too much from this new type. What's the thought behind a new type instead of using Arc<Client> directly?
There was a problem hiding this comment.
I like it. It has some value. It gives us HttpClientArc::default(), which should still work when we change the internals to be HttpClient interface. I think it also communicates how the library should be used.
|
I need to address ctaggart/autorust#86 first & then recreate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues from #80 and fixes #65. It is probably easiest to review #80 and ctaggart/autorust#86. This is the generated code.