Multiple instances #1010
Merged
Multiple instances #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cachelocation] in APIs
jasonnutter
reviewed
Sep 30, 2019
jasonnutter
reviewed
Sep 30, 2019
jasonnutter
reviewed
Sep 30, 2019
jasonnutter
reviewed
Sep 30, 2019
jasonnutter
reviewed
Sep 30, 2019
jasonnutter
reviewed
Sep 30, 2019
jasonnutter
reviewed
Sep 30, 2019
sameerag
changed the base branch from
state-keyed-cache
to
msal-multiple-instances
6 tasks
jasonnutter
suggested changes
Oct 11, 2019
|
Done. @pkanher617 @jasonnutter Can we please prioritize this tomorrow? |
pkanher617
reviewed
Oct 14, 2019
| @@ -467,12 +454,11 @@ export class UserAgentApplication { | |||
| // Push popup window handle onto stack for tracking | |||
| WindowUtils.trackPopup(popUpWindow); | |||
| } catch (e) { | |||
| this.loginInProgress = false; | |||
| this.acquireTokenInProgress = false; | |||
| this.cacheStorage.setItem(TemporaryCacheKeys.INTERACTION_STATUS, RequestStatus.CANCELLED); | |||
There was a problem hiding this comment.
Does setting to cancelled here do anything? Doesn't this get wiped out anyway during removeAcquireTokenEntries?
There was a problem hiding this comment.
Resetting interaction status since we bail out from here with a reject. removeAcquireTokenEntries() checks for this status to remove the entires for a request. So setting this to 'Cancelled' or 'Completed' is necessary.
pkanher617
approved these changes
Oct 14, 2019
|
@jasonnutter Added the comment. Can you please approve? |
jasonnutter
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support multiple instances of MSAL in the same window stack (i.e. in main window and iframe, two separate iframes, etc.).
Changes:
Note: @pkanher617 's PR #980 is moved to this PR with some additional changes