Skip to content

Multiple Instances in MSAL Pt. 1 - Cache Refactor and Adding Unique Keys #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 16, 2019
Merged

Multiple Instances in MSAL Pt. 1 - Cache Refactor and Adding Unique Keys #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec66919
Subclassing storage to encapsulate MSAL logic, moving class files
Sep 10, 2019
b4d1051
Finalizing changes, trying to fix tests (unsuccesfully)
Sep 11, 2019
308eab0
Renamed storage classes
Sep 12, 2019
cfcae69
Changes consts to enums in the constants file
Sep 12, 2019
71b7509
Adding check for window object, removing redundant checks for window[…
Sep 12, 2019
9d8a81a
Adding code improvements
Sep 12, 2019
5c4c5cb
Added helper for clearing cookie items
Sep 12, 2019
37d94e5
Getting all tests to pass
Sep 13, 2019
52465a8
Fixing issues with cache, ready to merge with overall branch
Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/msal-core/src/ServerRequestParameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class ServerRequestParameters {
* @param request
*/
private validatePromptParameter (prompt: string) {
if (!([PromptState.LOGIN, PromptState.SELECT_ACCOUNT, PromptState.CONSENT, PromptState.NONE].indexOf(prompt) >= 0)) {
if ([PromptState.LOGIN, PromptState.SELECT_ACCOUNT, PromptState.CONSENT, PromptState.NONE].indexOf(prompt) < 0) {
throw ClientConfigurationError.createInvalidPromptError(prompt);
}
}
Expand Down
197 changes: 0 additions & 197 deletions lib/msal-core/src/Storage.ts
View file
Open in desktop

This file was deleted.

Loading