Skip to content

Multiple Instances in MSAL Pt. 1 - Cache Refactor and Adding Unique Keys #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 16, 2019

Conversation

pkanher617
Copy link
Contributor

This PR is the first in a series to support multiple instances of MSAL in the same window stack (i.e. in main window and iframe, two separate iframes, etc.).

This PR covers a few changes:

  • Cleaning up the Storage class to make room for future improvements
  • Introducing new functionality to make unique keys in the cache tied to each instance of MSAL
  • Cleaning up the Constants.ts file to properly organize string constants and cache keys
  • Introduction of new Storage mechanics to UserAgentApplication
  • Migration from old cache signatures to new ones
  • Unit tests

@sameerag
Copy link
Member

Feedback:

  • Better naming for AuthStorage.ts and MSALStorage.ts
  • Retain writing to old cache values to facilitate rollbacks

@DarylThayil
Copy link
Contributor

all in all, code looks good to me and we talked through design yesterday. If others are happy with where we landed so am I

@pkanher617 pkanher617 marked this pull request as ready for review September 13, 2019 01:12
@pkanher617 pkanher617 changed the base branch from dev to authority_rebase September 16, 2019 22:20
@pkanher617 pkanher617 changed the base branch from authority_rebase to iframes_authRedirect September 16, 2019 22:21
@sameerag sameerag merged commit 52465a8 into iframes_authRedirect Sep 16, 2019
@sameerag sameerag mentioned this pull request Oct 4, 2019
@pkanher617 pkanher617 deleted the msal-multiple-instances branch December 12, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants