-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Multiple Instances in MSAL Pt. 1 - Cache Refactor and Adding Unique Keys #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
reviewed
Sep 11, 2019
Feedback:
|
jasonnutter
reviewed
Sep 12, 2019
jasonnutter
reviewed
Sep 12, 2019
jasonnutter
reviewed
Sep 12, 2019
jasonnutter
reviewed
Sep 12, 2019
jasonnutter
reviewed
Sep 12, 2019
jasonnutter
reviewed
Sep 12, 2019
jasonnutter
reviewed
Sep 12, 2019
all in all, code looks good to me and we talked through design yesterday. If others are happy with where we landed so am I |
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a series to support multiple instances of MSAL in the same window stack (i.e. in main window and iframe, two separate iframes, etc.).
This PR covers a few changes: