Skip to content

trainmap section theme #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: mc1.20.1/dev
Choose a base branch
from

Conversation

Vap0r1ze
Copy link
Contributor

This adds a new "Sections" theme for the train map, where you can see the sections of the train network on the map in the same way as if you were holding a train signal.

Previews:
javaw_BEnwkwXmzM
javaw_nxptDymyet

@VoidLeech VoidLeech added the pr type: feature PR adds a new feature or changes an existing feature label Apr 25, 2025
@Vap0r1ze
Copy link
Contributor Author

I'm willing to make this feature accessible differently, it's currently accessible via CClient.TrainMapTheme.SECTION. If y'all think it's best to ship this as a widget toggle, or ship it alongside sprites for signals let me know.

It's worth noting theres an issue that still needs to be addressed where rails on a lower y-level can render on top of rails on a higher y-level, though I plan on fixing this before merge

@JensenJ
Copy link
Contributor

JensenJ commented Apr 26, 2025

Not that I have any authority at all in the matter, so feel free to ignore. But personally, I think a toggle widget would be quite useful and my preferred way of accessing this feature, as it seems the kind of thing that you'd want to quickly turn on and off.

Switching themes through the ingame config viewer may be cumbersome for some, not to mention some people may not know you can switch the theme at all. This may be out of scope for this specific PR, but maybe a selection for all themes on the map screen may be worthwhile?

As for showing signals on the map, I think it may get a little cluttered at tight junctions, etc. If you were to do this I'd just be mindful of that. However, it would be quite nice to have that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr type: feature PR adds a new feature or changes an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants