fix(tracing): truncate long span attributes #13270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p if it is more than the buffer for resource names.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 233 ± 2 ms. The average import time from base is: 235 ± 2 ms. The import time difference between this PR and base is: -2.1 ± 0.1 ms. Import time breakdownThe following import paths have appeared:
|
BenchmarksBenchmark execution time: 2025-04-29 15:49:33 Comparing candidate commit fac94e0 in PR branch Found 12 performance improvements and 0 performance regressions! Performance is the same for 489 metrics, 7 unstable metrics. scenario:packagesupdateimporteddependencies-import_many
scenario:packagesupdateimporteddependencies-import_many_cached
scenario:packagesupdateimporteddependencies-import_many_stdlib
scenario:packagesupdateimporteddependencies-import_many_stdlib_cached
scenario:packagesupdateimporteddependencies-import_many_unknown
scenario:packagesupdateimporteddependencies-import_many_unknown_cached
scenario:packagesupdateimporteddependencies-import_one
scenario:packagesupdateimporteddependencies-import_one_cache
scenario:packagesupdateimporteddependencies-import_one_stdlib
scenario:packagesupdateimporteddependencies-import_one_stdlib_cache
scenario:packagesupdateimporteddependencies-import_one_unknown
scenario:packagesupdateimporteddependencies-import_one_unknown_cache
|
quinna-h
changed the title
add release note update test and snapshot
quinna-h
force-pushed
the
quinna/truncate-long-attributes
branch
from
3b9bf18 to
d21d413
Compare
mabdinur
approved these changes
Apr 28, 2025
releasenotes/notes/truncate-long-span-attributes-a4900ee9844160b4.yaml
Outdated
Show resolved
Hide resolved
2 tasks
wantsui
reviewed
Apr 28, 2025
wantsui
reviewed
Apr 28, 2025
juanjux
approved these changes
Apr 29, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3 3.3
# Navigate to the new working tree
cd .worktrees/backport-3.3
# Create a new branch
git switch --create backport-13270-to-3.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5aa32d185920544be12ca8372c74672b4f171a44
# Push it to GitHub
git push --set-upstream origin backport-13270-to-3.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.4 3.4
# Navigate to the new working tree
cd .worktrees/backport-3.4
# Create a new branch
git switch --create backport-13270-to-3.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5aa32d185920544be12ca8372c74672b4f171a44
# Push it to GitHub
git push --set-upstream origin backport-13270-to-3.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.4Then, create a pull request where the |
2 tasks
brettlangdon
pushed a commit
that referenced
this pull request
May 6, 2025
Truncate span resource name, tag key and tag values. Previously, a very large resource name would result in a runtime error during encoding. If any of these have over 25000 chars, this will truncate them to up to 2500 chars (and include the suffix `<truncated>`) The agent will truncate based on the limits [here](https://docs.datadoghq.com/tracing/troubleshooting/?tab=java#data-volume-guidelines) Resolves: - #13221 - #6587 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <[email protected]> Co-authored-by: wan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate span resource name, tag key and tag values.
Previously, a very large resource name would result in a runtime error during encoding.
If any of these have over 25000 chars, this will truncate them to up to 2500 chars (and include the suffix
<truncated>)The agent will truncate based on the limits here
Resolves:
Checklist
Reviewer Checklist