Bug Fix: handle non existent data field in paginated data #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new list user saved searches returns no data field in the page if there is none. A logged in user will get this error in the console: ``` TypeError: a.data is not iterable (cannot read property undefined) ``` This solves that
jcscottiii
changed the title
KyleJu
approved these changes
Apr 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
list user saved searchesreturns nodatafield in the page if there is none. That list method uses a helper method that does the iteration for us. But previous routes always had a data field in the objectA logged in user will get this error in the console:
As well as see a toast like this:
This solves that
Long term, we should decide if we should provide the data field for all paginated routes. Even if there is no data.