Improve thrown error message when attempting to draw a destroyed FlxGraphic #3417
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message that is thrown when attempting to draw a destroyed graphic currently is vague. It doesn't say what it tried to access, but was destroyed:
It is harder to troubleshoot the issue if you don't know which graphic is getting destroyed when its not supposed to. Thanks to this PR, the key of a FlxGraphic isn't set to null when the graphic is destroyed. This means that it can be used in the thrown error message:
This aids in the process of figuring out which graphic was destroyed so you can start working on finding where it got destroyed.