Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Add config to build aarch64 wheels #12

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add config to build aarch64 wheels #12

merged 1 commit into from
Oct 6, 2020

Conversation

janaknat
Copy link
Contributor

Travis-CI allows for the creation of aarch64 wheels.

Note:

  • This needs the latest multibuild. Update the submodule to point to the latest.

@janaknat
Copy link
Contributor Author

@grlee77
Copy link
Collaborator

grlee77 commented Sep 23, 2020

Thanks @janaknat

I know multibuild has moved away from using Rackspace for storing wheels, but haven't tried using it since that change was made. I will try to take a look later and see if just updating multibuild is sufficient for solving that or if there are any other changes needed on our end.

@janaknat
Copy link
Contributor Author

@grlee77 One of the needs for updating multibuild was that

install_run $PLAT

in .travis.yml does not understand the PLAT=aarch64 option in older versions of multibuild.

That command is found under travis_linux_steps.sh and was updated to recognize aarch64.
https://github.com/matthew-brett/multibuild/blob/6e9f609a33d78baaa96b92ad8d876bc90dcc7741/travis_linux_steps.sh#L126

There were other build issues with the older version which I didn't see on updating to the newer version.

Also, I ran the build again on travis-ci.org.
See build log: https://travis-ci.org/github/janaknat/pywavelets-wheels/builds/729672291

In the link I posted before, it was running in travis-ci.com.

@janaknat
Copy link
Contributor Author

@grlee77 Were you able to check the new version of multibuild?

@grlee77
Copy link
Collaborator

grlee77 commented Sep 29, 2020

Hi @janaknat: I just started #13 to work on switching the uploads to anaconda.org

@janaknat
Copy link
Contributor Author

@grlee77 Thanks!

@grlee77
Copy link
Collaborator

grlee77 commented Oct 5, 2020

Can you rebase on master now that #13 was merged?

@janaknat
Copy link
Contributor Author

janaknat commented Oct 5, 2020

@grlee77 I've rebased to master. A large chunk of time is spent on building numpy. Is it feasible to have a dependency on numpy>=1.19.1? That is the version that started shipping aarch64 wheels.

@grlee77
Copy link
Collaborator

grlee77 commented Oct 6, 2020

A large chunk of time is spent on building numpy. Is it feasible to have a dependency on numpy>=1.19.1? That is the version that started shipping aarch64 wheels.

That seems okay to me. I think that would be consistent with how the other NumPy pinnings are currently set (the pinnings are the oldest NumPy release that had x86 wheels available for a given version of Python).

@janaknat
Copy link
Contributor Author

janaknat commented Oct 6, 2020

@grlee77 Okay, I'll update the branch to use the latest numpy.

@janaknat
Copy link
Contributor Author

janaknat commented Oct 6, 2020

Gah! Have a typo. Resend again. Apologies.

@grlee77
Copy link
Collaborator

grlee77 commented Oct 6, 2020

Thanks, I will go ahead and merge this and see if the new wheels end up at multibuild-wheels-staging as expected

@grlee77 grlee77 merged commit f2a5ab2 into MacPython:master Oct 6, 2020
@janaknat
Copy link
Contributor Author

janaknat commented Oct 7, 2020

@grlee77 Thanks for merging. Is there a timeline for when the wheels will be available on PyPI?

@grlee77
Copy link
Collaborator

grlee77 commented Oct 7, 2020

@grlee77 Thanks for merging. Is there a timeline for when the wheels will be available on PyPI?

@rgommers: Do you have any objection to downloading the v1.1.1 AArch64 wheels from multibuild-wheels-staging and and uploading them to PyPI? I saw you were hesitant to add new wheels to an existing release for SciPy (scipy/scipy#11170 (comment)).

I am inclined to try it and if it causes any problems we can remove the wheels and wait until the subsequent release.

@rgommers
Copy link
Collaborator

rgommers commented Oct 7, 2020

Yes, I think we can try it. The risk is low, and PyWavelets is much smaller than SciPy so it's not likely this will cause problems for anyone.

Thanks for working on this.

@grlee77
Copy link
Collaborator

grlee77 commented Oct 8, 2020

Thanks Ralf! @janaknat: These AArch64 wheels are now on PyPI.

@janaknat
Copy link
Contributor Author

janaknat commented Oct 8, 2020

@grlee77 @rgommers Thanks a lot for your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants