Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

switch from Rackspace uploads to Anaconda.org #13

Merged
merged 12 commits into from
Oct 2, 2020

Conversation

grlee77
Copy link
Collaborator

@grlee77 grlee77 commented Sep 29, 2020

Hi @rgommers

I am trying to update this repo so that PyWavelets can upload staging wheels to anaconda.org instead of Rackspace. I don't think we need chron job uploads, but just want to upload when PRs here are merged.

@mattip: I saw that you recently helped the Astropy folks make the corresponding changes and would appreciate if you can provide feedback here as well, specifically on what scope is needed for the Anaconda token at multibuild-wheels-staging.

Here are the steps I have taken:

@mattip
Copy link
Contributor

mattip commented Sep 29, 2020

So far so good, but you still haven't gotten to the point where the upload is triggered: travis didn't run and appveyor failed to run the tests.

You might be interested in using github actions as in the dipy PR since they are better integrated with github, and provide an easy path for x86 based systems (mac, windows, linux).

As for scope of the tokens I am not sure. It would be nice to figure out the minimum requirements and put them on some documentation somewhere.

@grlee77
Copy link
Collaborator Author

grlee77 commented Sep 29, 2020

You might be interested in using github actions as in the dipy PR since they are better integrated with github, and provide an easy path for x86 based systems (mac, windows, linux).

I did see that recently, but hadn't taken a close look yet. There is a current request to add AArch64 wheels here. Would you recommend trying to build all x86 stuff via GitHub actions, but keep a Travis-CI case similar to this PR but with changes from #12 for AArch64? For now, I thought it might just be simpler to make these few modifications to the existing approach, but can reconsider as needed.

@grlee77
Copy link
Collaborator Author

grlee77 commented Sep 29, 2020

@tylerjereddy, when you configured SciPy wheels to move the uploads to anaconda.org, do you remember what scope(s) you enabled for the token at https://anaconda.org/multibuild-wheels-staging? There is a long list of options and I am unsure what the minimal scope needed to be able to upload wheels is. I could just enable "all", but thought a more minimal scope would be preferable from a security standpoint.

@grlee77
Copy link
Collaborator Author

grlee77 commented Sep 29, 2020

Appveyor pytest failures are apparently due to a env configuration option in our pytest.ini. We can install pytest-env here to avoid there error for now, but I have made a PR upstream to just remove this option: PyWavelets/pywt#569

@tylerjereddy
Copy link

@grlee77

do you remember what scope(s) you enabled for the token at https://anaconda.org/multibuild-wheels-staging

Yes, I followed the token creation instructions provided by Olivier Grisel to the SciPy mailing list on Feb. 12/2020, stating two things to activate:

  • Write access to API
  • Upload pypi packages

grlee77 and others added 2 commits September 29, 2020 23:33
PYWAVELETS_STAGING_UPLOAD_TOKEN was also regenerated with correct scope
Co-authored-by: Matti Picus <[email protected]>
@grlee77 grlee77 merged commit 34dd45d into MacPython:master Oct 2, 2020
@grlee77
Copy link
Collaborator Author

grlee77 commented Oct 2, 2020

Thank you @mattip and @tylerjereddy for your assistance. All wheels are now showing up at multibuild-wheels-staging!

For the record, the only two "scopes" I selected when creating the final Token were the ones suggested:

  • "Allow write access to the API site"
  • "Allow uploads to PyPI repositories"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants