Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app, components): Update copy/styling for default offset flow (DQA) #18048

Open
wants to merge 8 commits into
base: chore_release-8.4.0
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Apr 11, 2025

Closes RQA-4071, RQA-4070, and RQA-4069

Overview

This PR includes several styling/copy refactors for DQA.

df972a4 - Updates the banner copy after feedback. See RQA-4070.

70009f1 - Design has decided that the LPC banners should not display at once but should have a priority system. See RQA-4071.

2db91a9 - Banner state shouldn't really be kept in a hook since we have Redux. This commit just knocks out an outstanding TODO, adding tests for both this commit and 70009f1. Note that there was some inconsistent close behavior for the desktop/ODD banners given designs, but Design has decided to make only the default offset info banner dismissible now.

f28305e - Slight copy adjustment. In terms of copy (but not functionality), hardcoded offsets were counted as missing offsets if there were other outstanding missing offsets that were actually adjustable. Also fixes some singular/plural logic.

d861892 - Rename a component to prevent confusion.

481c215 - The top level ODD scrollbar is fun. This just prevents some screen resizing when the scrollbar renders.

ec5c4da - See RQA-4069. This component is only used for LPC (and legacy LPC), so there's no extensive blast radius here.

Screen.Recording.2025-04-11.at.11.35.19.AM.mov

RQA-4070 and RQA-4071

Screen.Recording.2025-04-11.at.12.31.16.PM.mov

RQA-4069

Test Plan and Hands on Testing

  • See videos.

Risk assessment

low - pretty much all stylistic changes, and the functional changes (the banner behavior) is easy to validate.

@mjhuff mjhuff requested review from koji, sfoster1, SyntaxColoring, jerader and a team April 11, 2025 16:44
@mjhuff mjhuff requested a review from a team as a code owner April 11, 2025 16:44
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes in components look good to me.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 1.73913% with 113 lines in your changes missing coverage. Please review.

Project coverage is 28.84%. Comparing base (a55df6c) to head (8325f9d).
Report is 6 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...abware/LPCLabwareDetails/OffsetBannerContainer.tsx 0.00% 50 Missing ⚠️
app/src/redux/protocol-runs/reducer/lpc.ts 0.00% 13 Missing ⚠️
...dux/protocol-runs/selectors/lpc/labware/offsets.ts 0.00% 11 Missing ⚠️
app/src/redux/protocol-runs/selectors/lpc/ui.ts 0.00% 8 Missing ⚠️
app/src/redux/protocol-runs/actions/lpc.ts 0.00% 6 Missing ⚠️
...rc/redux/protocol-runs/selectors/lpc/transforms.ts 0.00% 5 Missing ⚠️
app/src/pages/ODD/ProtocolSetup/index.tsx 0.00% 4 Missing ⚠️
...itionCheck/LPCFlows/hooks/useInitLPCStore/index.ts 0.00% 3 Missing ⚠️
...nents/src/hardware-sim/Pipette/EmanatingNozzle.tsx 0.00% 3 Missing ⚠️
...yApplyHistoricOffsets/LegacyLabwareOffsetTable.tsx 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #18048      +/-   ##
=======================================================
- Coverage                28.87%   28.84%   -0.03%     
=======================================================
  Files                     3106     3110       +4     
  Lines                   235782   235982     +200     
  Branches                 19122    19121       -1     
=======================================================
- Hits                     68074    68068       -6     
- Misses                  167684   167890     +206     
  Partials                    24       24              
Flag Coverage Δ
protocol-designer 18.78% <1.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/organisms/LabwarePositionCheck/LPCWizardFlex.tsx 0.00% <ø> (ø)
...ePositionCheck/__fixtures__/mockLPCContentProps.ts 0.00% <ø> (ø)
.../src/organisms/LabwarePositionCheck/hooks/index.ts 0.00% <ø> (ø)
...rc/organisms/LabwarePositionCheck/types/content.ts 100.00% <100.00%> (ø)
app/src/redux/protocol-runs/selectors/lpc/index.ts 0.00% <ø> (ø)
app/src/redux/protocol-runs/types/lpc/actions.ts 100.00% <ø> (ø)
app/src/redux/protocol-runs/types/lpc/store.ts 100.00% <ø> (ø)
app/src/redux/protocol-runs/types/lpc/ui.ts 100.00% <100.00%> (ø)
...ponents/src/hardware-sim/Pipette/PipetteRender.tsx 82.75% <ø> (-1.12%) ⬇️
...ck/steps/HandleLabware/LPCLabwareDetails/index.tsx 0.00% <0.00%> (ø)
... and 14 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjhuff mjhuff force-pushed the app_update-lpc-default-offset-banners branch 3 times, most recently from 57643ab to 8325f9d Compare April 11, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants