-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app, components): Update copy/styling for default offset flow (DQA) #18048
Open
mjhuff
wants to merge
8
commits into
chore_release-8.4.0
Choose a base branch
from
app_update-lpc-default-offset-banners
base: chore_release-8.4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
reviewed
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes in components look good to me.
57643ab
to
8325f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-4071, RQA-4070, and RQA-4069
Overview
This PR includes several styling/copy refactors for DQA.
df972a4 - Updates the banner copy after feedback. See RQA-4070.
70009f1 - Design has decided that the LPC banners should not display at once but should have a priority system. See RQA-4071.
2db91a9 - Banner state shouldn't really be kept in a hook since we have Redux. This commit just knocks out an outstanding TODO, adding tests for both this commit and 70009f1. Note that there was some inconsistent close behavior for the desktop/ODD banners given designs, but Design has decided to make only the default offset info banner dismissible now.
f28305e - Slight copy adjustment. In terms of copy (but not functionality), hardcoded offsets were counted as missing offsets if there were other outstanding missing offsets that were actually adjustable. Also fixes some singular/plural logic.
d861892 - Rename a component to prevent confusion.
481c215 - The top level ODD scrollbar is fun. This just prevents some screen resizing when the scrollbar renders.
ec5c4da - See RQA-4069. This component is only used for LPC (and legacy LPC), so there's no extensive blast radius here.
Screen.Recording.2025-04-11.at.11.35.19.AM.mov
RQA-4070 and RQA-4071
Screen.Recording.2025-04-11.at.12.31.16.PM.mov
RQA-4069
Test Plan and Hands on Testing
Risk assessment
low - pretty much all stylistic changes, and the functional changes (the banner behavior) is easy to validate.