Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app, components): Update copy/styling for default offset flow (DQA) #18048

Open
wants to merge 8 commits into
base: chore_release-8.4.0
Choose a base branch
from

lint

8325f9d
Select commit
Loading
Failed to load commit list.
Open

refactor(app, components): Update copy/styling for default offset flow (DQA) #18048

lint
8325f9d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 11, 2025 in 0s

28.84% (-0.03%) compared to a55df6c

View this Pull Request on Codecov

28.84% (-0.03%) compared to a55df6c

Details

Codecov Report

Attention: Patch coverage is 1.73913% with 113 lines in your changes missing coverage. Please review.

Project coverage is 28.84%. Comparing base (a55df6c) to head (8325f9d).
Report is 6 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...abware/LPCLabwareDetails/OffsetBannerContainer.tsx 0.00% 50 Missing ⚠️
app/src/redux/protocol-runs/reducer/lpc.ts 0.00% 13 Missing ⚠️
...dux/protocol-runs/selectors/lpc/labware/offsets.ts 0.00% 11 Missing ⚠️
app/src/redux/protocol-runs/selectors/lpc/ui.ts 0.00% 8 Missing ⚠️
app/src/redux/protocol-runs/actions/lpc.ts 0.00% 6 Missing ⚠️
...rc/redux/protocol-runs/selectors/lpc/transforms.ts 0.00% 5 Missing ⚠️
app/src/pages/ODD/ProtocolSetup/index.tsx 0.00% 4 Missing ⚠️
...itionCheck/LPCFlows/hooks/useInitLPCStore/index.ts 0.00% 3 Missing ⚠️
...nents/src/hardware-sim/Pipette/EmanatingNozzle.tsx 0.00% 3 Missing ⚠️
...yApplyHistoricOffsets/LegacyLabwareOffsetTable.tsx 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #18048      +/-   ##
=======================================================
- Coverage                28.87%   28.84%   -0.03%     
=======================================================
  Files                     3106     3110       +4     
  Lines                   235782   235982     +200     
  Branches                 19122    19121       -1     
=======================================================
- Hits                     68074    68068       -6     
- Misses                  167684   167890     +206     
  Partials                    24       24
Files with missing lines Coverage Δ
...c/organisms/LabwarePositionCheck/LPCWizardFlex.tsx 0.00% <ø> (ø)
...ePositionCheck/__fixtures__/mockLPCContentProps.ts 0.00% <ø> (ø)
.../src/organisms/LabwarePositionCheck/hooks/index.ts 0.00% <ø> (ø)
...rc/organisms/LabwarePositionCheck/types/content.ts 100.00% <100.00%> (ø)
app/src/redux/protocol-runs/selectors/lpc/index.ts 0.00% <ø> (ø)
app/src/redux/protocol-runs/types/lpc/actions.ts 100.00% <ø> (ø)
app/src/redux/protocol-runs/types/lpc/store.ts 100.00% <ø> (ø)
app/src/redux/protocol-runs/types/lpc/ui.ts 100.00% <100.00%> (ø)
...ponents/src/hardware-sim/Pipette/PipetteRender.tsx 82.75% <ø> (-1.12%) ⬇️
...ck/steps/HandleLabware/LPCLabwareDetails/index.tsx 0.00% <0.00%> (ø)
... and 14 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov