-
Notifications
You must be signed in to change notification settings - Fork 112
Fix Krylov tutorial being Heron-specific #3389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mirko Amico <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
One or more of the following people are relevant to this code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should just leave out the min_num_qubits
argument in the backend? The way it is written now (156q minimum) will not pick any backend if the user only has access to eagle devices (127q) or the ibm_torino qpu (133q), which is basically all the open plan users
Do you remember why it was changed in the first place? I was only copying your change. I'm happy to revert it back to 127. I think @beckykd normally has us set the argument so that things like simulators aren't used, iirc? Or maybe it's a holdover from when we had smaller devices and isn't necessary anymore? |
Oh I see. The 156 suggests an attempt to force the use of the latest heron devices but that actually cuts out open plan users so we should probably not do it. 127 would be good as it allows both eagles and older herons to be selected |
Isn't 127 the minimum that we have? We might as well just leave it off. And yes, I usually include an argument that ensures that a simulator isn't used: "simulator=False" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #3202. See #3217 for the original PR.