Skip to content

Fix Krylov tutorial being Heron-specific #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Fix Krylov tutorial being Heron-specific #3389

merged 2 commits into from
Jun 20, 2025

Conversation

Eric-Arellano
Copy link
Collaborator

Closes #3202. See #3217 for the original PR.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

Copy link
Collaborator

@miamico miamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should just leave out the min_num_qubits argument in the backend? The way it is written now (156q minimum) will not pick any backend if the user only has access to eagle devices (127q) or the ibm_torino qpu (133q), which is basically all the open plan users

@Eric-Arellano
Copy link
Collaborator Author

Eric-Arellano commented Jun 20, 2025

maybe we should just leave out the min_num_qubits argument in the backend?

Do you remember why it was changed in the first place? I was only copying your change. I'm happy to revert it back to 127.

I think @beckykd normally has us set the argument so that things like simulators aren't used, iirc? Or maybe it's a holdover from when we had smaller devices and isn't necessary anymore?

@miamico
Copy link
Collaborator

miamico commented Jun 20, 2025

Oh I see. The 156 suggests an attempt to force the use of the latest heron devices but that actually cuts out open plan users so we should probably not do it. 127 would be good as it allows both eagles and older herons to be selected

@beckykd
Copy link
Collaborator

beckykd commented Jun 20, 2025

127 would be good

Isn't 127 the minimum that we have? We might as well just leave it off. And yes, I usually include an argument that ensures that a simulator isn't used: "simulator=False"

Copy link
Collaborator

@miamico miamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit e067431 Jun 20, 2025
4 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/kqd-fix2 branch June 20, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

KQD tutorial - KeyError while transpiling to QPUs
4 participants