This repository was archived by the owner on May 30, 2024. It is now read-only.
Add tests for HEREDOC patterns #842
Merged
+355
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
force-pushed
the
heredoc-pattern-tests
branch
2 times, most recently
from
77dcd68 to
341909a
Compare
sambostock
force-pushed
the
heredoc-pattern-tests
branch
2 times, most recently
from
5ca6c02 to
37da827
Compare
We have many patterns for embedded languages in HEREDOCs, and manually ensuring they are correct can be problematic. This introduces tests to enforce their correctness, generated from an easier to manage minimal config.
sambostock
force-pushed
the
heredoc-pattern-tests
branch
from
37da827 to
513dbc9
Compare
This was referenced Oct 18, 2023
vinistock
approved these changes
Oct 19, 2023
| @@ -3,7 +3,7 @@ | |||
| "module": "commonjs", | |||
| "target": "ES2020", | |||
| "outDir": "out", | |||
| "lib": ["ES2020"], | |||
| "lib": ["dom", "ESNext"], | |||
There was a problem hiding this comment.
ESNextis needed forArray#toSorteddomis needed forWebAssembly&Responsetypes, which are used bynode_modules/vscode-oniguruma/main.d.ts1
AFAIK the code still ends up the same though, as target hasn't changed.
Footnotes
There was a problem hiding this comment.
I made a few tests and it seems like everything is fine after changing the targets. Let's move forward with this and I can make a preview extension release just to confirm the compilation works - before doing the stable release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have many patterns for embedded languages in HEREDOCs, and manually ensuring they are correct can be problematic, especially as we want to add new ones (e.g.
YAML).Implementation
This introduces tests to enforce their correctness, generated from an easier to manage minimal config. It also adds tests to actually check that the grammar results in parsing the expected tokens.
Automated Tests
The first commit consists of only tests. 📈
The second commit is a TDD change to capitalization.
Manual Tests
If heredoc highlighting continues to work, everything is working.