Add speculative support for zstd compressed chunks #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
force-pushed
the
depot-compression
branch
from
00e7ec9 to
fac7eb9
Compare
xPaw
force-pushed
the
depot-compression
branch
from
fac7eb9 to
a695ef1
Compare
Nuclearistt
reviewed
Feb 17, 2025
| { | ||
| static class VZstdUtil | ||
| { | ||
| private const uint VZstdHeader = 0x56535A61; |
There was a problem hiding this comment.
This should be changed to 0x615A5356 since endianness is "reversed" in number literals, i.e the 2 rightmost characters is the value of the first byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1503. Do not merge yet as I haven't actually tested it - need to wait for some chunks that actually use this.