-
Notifications
You must be signed in to change notification settings - Fork 507
Add speculative support for zstd compressed chunks #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
xPaw
wants to merge
2
commits into
master
Choose a base branch
from
depot-compression
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−1
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
using System; | ||
using System.Buffers; | ||
using System.IO; | ||
using System.Runtime.InteropServices; | ||
|
||
namespace SteamKit2 | ||
{ | ||
static class VZstdUtil | ||
{ | ||
private const uint VZstdHeader = 0x56535A61; | ||
|
||
public static int Decompress( ReadOnlySpan<byte> buffer, byte[] destination ) | ||
{ | ||
if ( MemoryMarshal.Read<uint>( buffer ) != VZstdHeader ) | ||
{ | ||
throw new InvalidDataException( "Expecting VZstdHeader at start of stream" ); | ||
} | ||
|
||
var sizeCompressed = MemoryMarshal.Read<int>( buffer[ ^15.. ] ); // TODO: I am not convinced this is correct -- maybe its the frame size | ||
var sizeDecompressed = MemoryMarshal.Read<int>( buffer[ ^11.. ] ); | ||
|
||
if ( buffer[ ^3 ] != 'z' || buffer[ ^2 ] != 's' || buffer[ ^1 ] != 'v' ) | ||
{ | ||
throw new InvalidDataException( "Expecting VZstdFooter at end of stream" ); | ||
} | ||
|
||
if ( destination.Length < sizeDecompressed ) | ||
{ | ||
throw new ArgumentException( "The destination buffer is smaller than the decompressed data size.", nameof( destination ) ); | ||
} | ||
|
||
using var zstdDecompressor = new ZstdSharp.Decompressor(); | ||
|
||
var input = buffer[ 4..^12 ]; | ||
|
||
if ( !zstdDecompressor.TryUnwrap( input, destination, out var sizeWritten ) || sizeDecompressed != sizeWritten ) | ||
{ | ||
throw new InvalidDataException( $"Failed to decompress Zstd (expected {sizeDecompressed} bytes, got {sizeWritten})." ); | ||
} | ||
|
||
return sizeDecompressed; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to 0x615A5356 since endianness is "reversed" in number literals, i.e the 2 rightmost characters is the value of the first byte