feat(ui): Added UI component for reasoning models #4075
+49
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JovenSoh
changed the title
wsxiaoys
reviewed
Mar 25, 2025
Comment on lines
175
to
181
| findMatches( | ||
| MARKDOWN_THINK_REGEX, | ||
| ThinkPlaceholder, | ||
| (match: RegExpExecArray) => ({ | ||
| content: decodeURIComponent(match[1]) | ||
| }) | ||
| ) |
There was a problem hiding this comment.
instead of converting from PLACEHOLDER_THINK_REGEX format to MARKDOWN_THINK_REGEX format, can we just use PLACEHOLDER_THINK_REGEX here to render the think content?
wsxiaoys
reviewed
Mar 25, 2025
| @@ -396,6 +406,29 @@ export function ErrorMessageBlock({ | |||
| ) | |||
| } | |||
|
|
|||
| function ThinkPlaceholder({ content }: { content: string }): JSX.Element { | |||
There was a problem hiding this comment.
Suggested change
| function ThinkPlaceholder({ content }: { content: string }): JSX.Element { | |
| function ThinkBlock({ content }: { content: string }): JSX.Element { |
nit
wsxiaoys
reviewed
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #3977
Adds a collapsible section that contains the reasoning steps of models such as deepseek-r1.
https://jam.dev/c/56380060-dbfa-4746-9cbd-f41ee3a4375c
Has light and dark variation.
Currently unable to collapse component during reasoning.
Before:
