-
-
Notifications
You must be signed in to change notification settings - Fork 444
feat(core): form listeners #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 35e8458.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 88.83% 88.86% +0.03%
==========================================
Files 31 31
Lines 1379 1383 +4
Branches 347 347
==========================================
+ Hits 1225 1229 +4
Misses 137 137
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
67f962d
to
42e0bc0
Compare
Note to self: move onChange out of the form listeners debounce logic and implement it in form [edit] resolved |
4005416
to
44a8474
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor
Hey, awesome addition! If this also had debounceMs i could replace a listener i've added to all fields in a form 🚀 (though of course it's a nit!) |
@MartinCura hmm that makes sense to me... would also keep it more consistent across the form and field levels, give me a day or two. 😄 |
@MartinCura might be worth exploring TanStack Pacer in the meantime 👀 |
Uuuh didn't know about that one! Though it makes sense as it looks quite new. Don't worry, used field listeners (replacing a |
@MartinCura I've implemented the debounced listeners just now... I'm waiting for a review and I'll deploy it 😄 Enjoy the weekend! |
You're a machine. Danke schön ! |
@MartinCura Kein problem, It was just deployed... enjoy the new feature! |
Adds form listeners to formApi.