Skip to content

feat(core): form listeners #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2025
Merged

Conversation

harry-whorlow
Copy link
Contributor

Adds form listeners to formApi.

Copy link

nx-cloud bot commented Mar 9, 2025

View your CI Pipeline Execution ↗ for commit 35e8458.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 44s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 12:53:25 UTC

Copy link

pkg-pr-new bot commented Mar 9, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1261

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1261

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1261

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1261

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1261

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1261

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1261

commit: 35e8458

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (0c79f24) to head (35e8458).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
+ Coverage   88.83%   88.86%   +0.03%     
==========================================
  Files          31       31              
  Lines        1379     1383       +4     
  Branches      347      347              
==========================================
+ Hits         1225     1229       +4     
  Misses        137      137              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow
Copy link
Contributor Author

harry-whorlow commented Mar 9, 2025

Do not merge until 'infinite type' I've fixed 🤟

Screenshot 2025-03-09 at 21 58 45

@harry-whorlow harry-whorlow marked this pull request as ready for review March 12, 2025 11:07
@harry-whorlow harry-whorlow force-pushed the form-listerners branch 4 times, most recently from 67f962d to 42e0bc0 Compare April 16, 2025 07:35
@harry-whorlow
Copy link
Contributor Author

harry-whorlow commented Apr 18, 2025

Note to self: move onChange out of the form listeners debounce logic and implement it in form

[edit] resolved

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor

@harry-whorlow harry-whorlow merged commit 7e46037 into TanStack:main Apr 25, 2025
6 checks passed
@MartinCura
Copy link

Hey, awesome addition! If this also had debounceMs i could replace a listener i've added to all fields in a form 🚀 (though of course it's a nit!)

@harry-whorlow
Copy link
Contributor Author

@MartinCura hmm that makes sense to me... would also keep it more consistent across the form and field levels, give me a day or two. 😄

@Balastrong
Copy link
Member

@MartinCura might be worth exploring TanStack Pacer in the meantime 👀

@MartinCura
Copy link

@MartinCura might be worth exploring TanStack Pacer in the meantime 👀

Uuuh didn't know about that one! Though it makes sense as it looks quite new.

Don't worry, used field listeners (replacing a useDebounce from another library). Grazie! Keep up the good work (and yt channel)!

@harry-whorlow
Copy link
Contributor Author

@MartinCura I've implemented the debounced listeners just now... I'm waiting for a review and I'll deploy it 😄

Enjoy the weekend!

@MartinCura
Copy link

@MartinCura I've implemented the debounced listeners just now... I'm waiting for a review and I'll deploy it 😄

Enjoy the weekend!

You're a machine. Danke schön !

@harry-whorlow
Copy link
Contributor Author

harry-whorlow commented Apr 27, 2025

@MartinCura Kein problem, It was just deployed... enjoy the new feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants