Skip to content

Rename respondWith()/canRespond → transitionWhile()/canTransition #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Rename respondWith()/canRespond → transitionWhile()/canTransition #151

merged 1 commit into from
Aug 18, 2021

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Aug 17, 2021 •
edited by pr-preview bot
Loading

Closes #94.

Preview | Diff

@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Aug 17, 2021
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2021
@domenic @chromium-wpt-export-bot
App history: rename respondWith() to transitionWhile()
d2d27f1 
... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2021
@domenic @chromium-wpt-export-bot
App history: rename respondWith() to transitionWhile()
839c300 
... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2021
@domenic @chromium-wpt-export-bot
App history: rename respondWith() to transitionWhile()
ab76d6d 
... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 18, 2021
@domenic @chromium-wpt-export-bot
App history: rename respondWith() to transitionWhile()
b53e409 
... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100807
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912818}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 18, 2021
@domenic @chromium-wpt-export-bot
App history: rename respondWith() to transitionWhile()
93e7dda 
... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100807
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912818}
pull bot pushed a commit to Yannic/chromium that referenced this pull request Aug 18, 2021
@domenic
App history: rename respondWith() to transitionWhile()
6cf2470 
... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100807
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912818}
@domenic domenic merged commit 86ee2dc into main Aug 18, 2021
@samthor samthor mentioned this pull request Aug 20, 2021
Closed
@domenic domenic deleted the transitionwhile branch August 20, 2021 17:26
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 3, 2021
@domenic @moz-wptsync-bot
Bug 1726231 [wpt PR 30060] - App history: rename respondWith() to tra…
2b9d855 
…nsitionWhile(), a=testonly

Automatic update from web-platform-tests
App history: rename respondWith() to transitionWhile()

... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100807
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912818}

--

wpt-commits: 93e7dda5c531edc5a636ac3bfb7d724483d0a6fb
wpt-pr: 30060
spinda pushed a commit to PLSysSec/icarus-firefox that referenced this pull request Sep 8, 2021
@domenic @moz-wptsync-bot
Bug 1726231 [wpt PR 30060] - App history: rename respondWith() to tra…
b60ec61 
…nsitionWhile(), a=testonly

Automatic update from web-platform-tests
App history: rename respondWith() to transitionWhile()

... and canRespond to canTransition.

Follows WICG/navigation-api#151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100807
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912818}

--

wpt-commits: 93e7dda5c531edc5a636ac3bfb7d724483d0a6fb
wpt-pr: 30060
@fabiancook fabiancook mentioned this pull request Dec 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple event handlers to call respondWith()
1 participant
@domenic