PostMessage Cleanup - TodoMVC example (experimental) #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
flashdesignory
changed the title
rniwa
approved these changes
Apr 23, 2025
rniwa
reviewed
Apr 23, 2025
| *************************************************************************/ | ||
| export class BenchmarkConnector { | ||
| constructor(suites, name, version) { | ||
| this.suites = suites; |
There was a problem hiding this comment.
Is there a benefit in refactoring? Maybe that's a larger conversation if we want to prefer private variables in our code and might be better to tackle in a separate discussion. This is consistent with the previous example that uses the postMessage api and I rather want to avoid larger changes in a single pr.
rniwa
reviewed
Apr 23, 2025
resources/todomvc/vanilla-examples/javascript-web-components/dist/src/benchmark.mjs
Outdated
Show resolved
Hide resolved
rniwa
reviewed
Apr 23, 2025
resources/todomvc/vanilla-examples/javascript-web-components/dist/src/params.mjs
Outdated
Show resolved
Hide resolved
rniwa
reviewed
Apr 23, 2025
resources/todomvc/vanilla-examples/javascript-web-components/dist/src/test-invoker.mjs
Outdated
Show resolved
Hide resolved
julienw
requested changes
May 5, 2025
resources/todomvc/vanilla-examples/javascript-web-components/scripts/build.js
Outdated
Show resolved
Hide resolved
resources/todomvc/vanilla-examples/javascript-web-components/scripts/build.js
Outdated
Show resolved
Hide resolved
resources/todomvc/vanilla-examples/javascript-web-components/scripts/build.js
Outdated
Show resolved
Hide resolved
resources/todomvc/vanilla-examples/javascript-web-components/scripts/build.js
Show resolved
Hide resolved
resources/todomvc/vanilla-examples/javascript-web-components/scripts/build.js
Outdated
Show resolved
Hide resolved
resources/todomvc/vanilla-examples/javascript-web-components/scripts/build.js
Show resolved
Hide resolved
…cripts/build.js Co-authored-by: Julien Wajsberg <[email protected]>
…cripts/build.js Co-authored-by: Julien Wajsberg <[email protected]>
…cripts/build.js Co-authored-by: Julien Wajsberg <[email protected]>
camillobruni
approved these changes
May 21, 2025
resources/todomvc/vanilla-examples/javascript-web-components/dist/src/index.js
Outdated
Show resolved
Hide resolved
julienw
approved these changes
May 21, 2025
rniwa
reviewed
May 21, 2025
rniwa
reviewed
May 21, 2025
.../todomvc/vanilla-examples/javascript-web-components/dist/src/speedometer-utils/benchmark.mjs
Show resolved
Hide resolved
rniwa
reviewed
May 21, 2025
.../todomvc/vanilla-examples/javascript-web-components/dist/src/speedometer-utils/benchmark.mjs
Show resolved
Hide resolved
rniwa
reviewed
May 21, 2025
...es/todomvc/vanilla-examples/javascript-web-components/dist/src/speedometer-utils/helpers.mjs
Show resolved
Hide resolved
rniwa
reviewed
May 21, 2025
...es/todomvc/vanilla-examples/javascript-web-components/dist/src/speedometer-utils/helpers.mjs
Show resolved
Hide resolved
rniwa
reviewed
May 21, 2025
|
|
||
| switch (event.data.type) { | ||
| case "benchmark-suite": | ||
| const params = new Params(new URLSearchParams(window.location.search)); |
There was a problem hiding this comment.
So we're gonna propagate location.search from the main frame to iframe?
Maybe it's easier this one just grabbed params out of top.location.search instead?
There was a problem hiding this comment.
what's the benefit of doing it this way?
There was a problem hiding this comment.
So that we don't have to propagate / forward the query string from the main document to the iframe's document.
There was a problem hiding this comment.
I think it would be nicer to explicitly forward this for debugging purposes. One would easily see the full URL including params for the frame in the network log and could open that separately.
Either approach would be fine.
rniwa
reviewed
May 21, 2025
...domvc/vanilla-examples/javascript-web-components/dist/src/speedometer-utils/test-invoker.mjs
Show resolved
Hide resolved
rniwa
reviewed
May 21, 2025
resources/todomvc/vanilla-examples/javascript-web-components/src/workload-test.mjs
Show resolved
Hide resolved
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr uses the todomvc web components workload and enables it for the post message api.
This is similar to what we've done for the news site example.
Benchmark changes
Workload changes
chrome:
safari:
todo: cb scores