Cleanup/shared #513
Open
Cleanup/shared #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
approved these changes
May 27, 2025
julienw
approved these changes
May 28, 2025
| @@ -13,7 +13,7 @@ export class BenchmarkStep { | |||
| this.run = run; | |||
| } | |||
|
|
|||
| async runAndRecord(params, suite, test, callback) { | |||
| async runAndRecordStep(params, suite, test, callback) { | |||
There was a problem hiding this comment.
shouldn't this one be "Test" instead of "Step"??
There was a problem hiding this comment.
thanks for the new comments, that's super useful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup as a result from comments in this pr: #509
resources/shared/helpers.mjs:
getParenttorecursivelyQuerySelectorresources/shared/test-invoker.mjs:
startmethod intoTestInvokerand removeBaseRAFTestInvokerclassresources/shared/benchmark.mjs
Open discussion:
resources/shared/benchmark.mjs - forward url params (current implementation), or grab from top.location.search?
pros: nicer to debug, since you can see the full url of the workload (including params)
cons: we have to propagate and forward the query string from the main document
Follow up:
run build scripts of postmessage enabled workloads