-
Notifications
You must be signed in to change notification settings - Fork 48
chore: Update codecov.yml #3971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
status: | ||
project: | ||
default: | ||
target: 80% | ||
# basic | ||
# target: 50% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here target is disabled does it mean we want to increase code coverage to 100% first then for each PR we will check that code coverage has been maintained otherwise the PR will not get merged ? I think we can enforce such condition so that it will help to maintain the code coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR requirement is determined by the patch target which is 90%. That means 90% of new changes should have test coverage. The project codebase (default target) doesn't have any requirement, however we shall work on to generally improve the coverage.
I'm also not sure how it is enforced during PR merge. E.g. in the main branch already has a similar target requirement, but I've never seen any status check corresponding to that while merging PRs.
We also need to fix why the coverage report in the main github page is showing 36%. I think the report is based on old codebase, although it should be updated during each nightly test run. I'll first update the .yaml as per the latest guide (this PR) and then look into if the CI requires some additional fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Last time I was working on increasing test coverage of file_transfer_service.py
, however even after adding appropriate tests it was showing same code coverage around 25%.
I had mentioned this issue to @seanpearsonuk but I understood now that it was not updating.
I have created a PR to check the coverage manually.
Let's see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get the lowest code coverage around 64% for 22R2 and highest 80% for 25R2
https://github.com/ansys/pyfluent/actions/runs/14836953788/job/41652990983?pr=4006
Updating codecov.yml from the latest PyAnsys developer's guide: https://dev.docs.pyansys.com/how-to/testing.html#enforce-code-coverage
Coverage report in this branch (showing the files with less that 50% test coverage)
