-
Notifications
You must be signed in to change notification settings - Fork 48
chore: Update codecov.yml #3971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkundu1
wants to merge
2
commits into
main
Choose a base branch
from
chore/codecov
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,22 @@ | ||
| comment: | ||
| layout: "diff" | ||
| behavior: default | ||
| require_changes: true # Avoid coverage comment if no files are changed. | ||
|
|
||
| coverage: | ||
| range: 70..100 | ||
| round: down | ||
| precision: 2 | ||
| status: | ||
| project: | ||
| default: | ||
| target: 80% | ||
| # basic | ||
| # target: 50% | ||
| threshold: 0% | ||
| # advanced | ||
| if_not_found: success | ||
| if_ci_failed: error | ||
| if_no_uploads: error | ||
| patch: | ||
| default: | ||
| # basic | ||
| target: 90% | ||
| if_not_found: success | ||
| if_ci_failed: error | ||
| if_no_uploads: error | ||
| threshold: 4% # Because some tests are flaky. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Update codecov.yml |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here target is disabled does it mean we want to increase code coverage to 100% first then for each PR we will check that code coverage has been maintained otherwise the PR will not get merged ? I think we can enforce such condition so that it will help to maintain the code coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR requirement is determined by the patch target which is 90%. That means 90% of new changes should have test coverage. The project codebase (default target) doesn't have any requirement, however we shall work on to generally improve the coverage.
I'm also not sure how it is enforced during PR merge. E.g. in the main branch already has a similar target requirement, but I've never seen any status check corresponding to that while merging PRs.
We also need to fix why the coverage report in the main github page is showing 36%. I think the report is based on old codebase, although it should be updated during each nightly test run. I'll first update the .yaml as per the latest guide (this PR) and then look into if the CI requires some additional fixes.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Last time I was working on increasing test coverage of
file_transfer_service.py, however even after adding appropriate tests it was showing same code coverage around 25%.https://app.codecov.io/gh/ansys/pyfluent/blob/main/src%2Fansys%2Ffluent%2Fcore%2Futils%2Ffile_transfer_service.py
I had mentioned this issue to @seanpearsonuk but I understood now that it was not updating.
I have created a PR to check the coverage manually.
#4006
Let's see.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get the lowest code coverage around 64% for 22R2 and highest 80% for 25R2
https://github.com/ansys/pyfluent/actions/runs/14836953788/job/41652990983?pr=4006