Minor: remove unnecessary dependencies in datafusion-sqllogictest
#14578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 10, 2025
| @@ -42,9 +42,6 @@ bytes = { workspace = true, optional = true } | |||
| chrono = { workspace = true, optional = true } | |||
| clap = { version = "4.5.16", features = ["derive", "env"] } | |||
| datafusion = { workspace = true, default-features = true, features = ["avro"] } | |||
| datafusion-catalog = { workspace = true, default-features = true } | |||
There was a problem hiding this comment.
The point of this PR is to remove these three lines
|
Thanks @alamb |
xudong963
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Noticed while working with @logan-keede on
datafusion-catalog-listing#14555Rationale for this change
Since
datafusion-sqllogictestalready depends ondatafusion(aka datafusion-core) which re-exports the needed items there is no reason to also depend on subcratesWhat changes are included in this PR?
remove unnecessary dependencies and update
usestatementsAre these changes tested?
By CI
Are there any user-facing changes?