-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Disable extended tests (extended_tests
) that are failing on runner
#14604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# # Run extended tests (with feature 'extended_tests') | ||
# # Disabling as it is running out of disk space | ||
# # see https://github.com/apache/datafusion/issues/14576 | ||
# linux-test-extended: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was added by @2010YOUY01 in
It started failing after
I suspect something about the test is using too much disk space
Note when I ran
cargo test --profile ci --exclude datafusion-examples --exclude datafusion-benchmarks --workspace --lib --tests --bins --features avro,json,backtrace,extended_tests
Locally, my target directory was 4GB
However, after extended_tests
ran, the target directory was 14GB
$ du -s -h target
14G target
14G target
I suspect what is happening is that sort mem validation call is somehow recompiling the entire workspace
datafusion/datafusion/core/tests/memory_limit/memory_limit_validation/sort_mem_validation.rs
Lines 81 to 95 in 0283077
let output = Command::new("cargo") | |
.arg("test") | |
.arg("--package") | |
.arg("datafusion") | |
.arg("--test") | |
.arg("core_integration") | |
.arg("--features") | |
.arg("extended_tests") | |
.arg("--") | |
.arg(&test_path) | |
.arg("--exact") | |
.arg("--nocapture") | |
.env("DATAFUSION_TEST_MEM_LIMIT_VALIDATION", "1") | |
.output() | |
.expect("Failed to execute test command"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the extended-tests
is the one which runs the sqllogic tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, you commented the other part of extended tests
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @alamb
It seems to have worked: |
Which issue does this PR close?
Rationale for this change
These tests are failing on main due to out of disk space (see #14576)
Here is an example: https://github.com/apache/datafusion/actions/runs/13261520752/job/37019301867

What changes are included in this PR?
Are these changes tested?
No
Are there any user-facing changes?
Hopefully we'll get the tests passing again on main