Skip to content

feat: implement predicate adaptation for nested structs #16589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

adriangb
Copy link
Contributor

Functionality equivalent to #16371 but for #16461.

@adriangb
Copy link
Contributor Author

Marking as draft until I have time do a review myself. @kosiew feel free to take a look if you have time but I expect this needs work before it's ready.

@adriangb adriangb marked this pull request as draft June 27, 2025 17:25
@adriangb adriangb self-assigned this Jun 27, 2025
@github-actions github-actions bot added physical-expr Changes to the physical-expr crates datasource Changes to the datasource crate labels Jun 27, 2025
@@ -135,6 +136,7 @@ datafusion-functions-window-common = { path = "datafusion/functions-window-commo
datafusion-macros = { path = "datafusion/macros", version = "48.0.0" }
datafusion-optimizer = { path = "datafusion/optimizer", version = "48.0.0", default-features = false }
datafusion-physical-expr = { path = "datafusion/physical-expr", version = "48.0.0", default-features = false }
datafusion-physical-expr-adapter = { path = "datafusion/physical-expr-adapter", version = "48.0.0", default-features = false }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make a new package because physical-expr does not have access to functions-nested

@adriangb adriangb requested a review from kosiew June 27, 2025 19:03
@adriangb adriangb marked this pull request as ready for review June 27, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource Changes to the datasource crate physical-expr Changes to the physical-expr crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant