-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: implement predicate adaptation for nested structs #16589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adriangb
wants to merge
10
commits into
apache:main
Choose a base branch
from
pydantic:nested-expr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+901
−469
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3dd130e
feat: implement predicate adaptation for nested structs
adriangb 5025a99
lint
adriangb 832d6fb
move
adriangb 9c5bcad
lint
adriangb ddb56ac
better tests
adriangb c9efea8
fmt
adriangb 36fcfe0
remove unused param
adriangb 070c134
fmt
adriangb 22196b5
remove duplication
adriangb cd5c193
fix
adriangb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
[package] | ||
name = "datafusion-physical-expr-adapter" | ||
description = "Physical expression schema adaptation utilities for DataFusion" | ||
keywords = ["datafusion", "query", "sql"] | ||
readme = "README.md" | ||
version = { workspace = true } | ||
edition = { workspace = true } | ||
homepage = { workspace = true } | ||
repository = { workspace = true } | ||
license = { workspace = true } | ||
authors = { workspace = true } | ||
rust-version = { workspace = true } | ||
|
||
[lib] | ||
name = "datafusion_physical_expr_adapter" | ||
path = "src/lib.rs" | ||
|
||
[dependencies] | ||
arrow = { workspace = true } | ||
datafusion-common = { workspace = true } | ||
datafusion-expr = { workspace = true } | ||
datafusion-functions = { workspace = true } | ||
datafusion-physical-expr = { workspace = true } | ||
datafusion-physical-expr-common = { workspace = true } | ||
itertools = { workspace = true } | ||
|
||
[dev-dependencies] | ||
datafusion-expr = { workspace = true } | ||
insta = { workspace = true } | ||
rstest = { workspace = true } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# DataFusion Physical Expression Adapter | ||
|
||
This crate provides physical expression schema adaptation utilities for DataFusion, with support for complex nested struct type handling. | ||
|
||
## Overview | ||
|
||
The `PhysicalExprSchemaRewriter` allows rewriting physical expressions to match different schemas, including: | ||
|
||
- Type casting when logical and physical schemas have different types | ||
- Handling missing columns by inserting null literals | ||
- Struct support: Recursive rebuilding of struct expressions with proper field mapping | ||
- Partition column replacement with literal values |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
#![doc( | ||
html_logo_url = "https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg", | ||
html_favicon_url = "https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg" | ||
)] | ||
#![cfg_attr(docsrs, feature(doc_auto_cfg))] | ||
|
||
//! Physical expression schema adaptation utilities for DataFusion | ||
|
||
pub mod schema_rewriter; | ||
|
||
pub use schema_rewriter::PhysicalExprSchemaRewriter; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make a new package because
physical-expr
does not have access tofunctions-nested