Fix MIRI CI run + and update nightly version used #3215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 21, 2022
| @@ -374,9 +374,7 @@ jobs: | |||
| MIRIFLAGS: "-Zmiri-disable-isolation" | |||
| run: | | |||
| cargo miri setup | |||
| cargo clean | |||
| # Ignore MIRI errors until we can get a clean run | |||
| cargo miri test || true | |||
There was a problem hiding this comment.
The MIRI test on master fails to even start. For example: https://github.com/apache/arrow-datafusion/runs/7932578950?check_suite_focus=true
A libstd for Miri is now available in `/home/runner/.cache/miri/HOST`.
Updating crates.io index
error: failed to select a version for the requirement `parquet = "^20.0.0"`
candidate versions found which didn't match: 15.0.0, 14.0.0, 13.0.0, ...
location searched: crates.io index
required by package `datafusion-common v11.0.0 (/home/runner/work/arrow-datafusion/arrow-datafusion/datafusion/common)`
Codecov Report
@@ Coverage Diff @@
## master #3215 +/- ##
==========================================
- Coverage 85.58% 85.58% -0.01%
==========================================
Files 296 296
Lines 54184 54184
==========================================
- Hits 46374 46373 -1
- Misses 7810 7811 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
force-pushed
the
alamb/new_nightly_miri
branch
from
e487834 to
a864c3e
Compare
|
Closing for a different approach: #3610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #3045
Rationale for this change
As suggested by @jackwener 👍
#3196 (comment)
What changes are included in this PR?
Are there any user-facing changes?