Skip to content

Fix MIRI CI run + and update nightly version used #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix MIRI CI run + and update nightly version used #3215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0744e8
Update nightly rust version used for MIRI
alamb Aug 21, 2022
a864c3e
stop ignoring MIRI runs
alamb Aug 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,8 @@ jobs:
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
- name: Setup Rust toolchain
run: |
rustup toolchain install nightly-2022-01-17
rustup default nightly-2022-01-17
rustup toolchain install nightly-2022-08-20
rustup default nightly-2022-08-20
rustup component add rustfmt clippy miri
- name: Run Miri Checks
env:
Expand All @@ -379,9 +379,7 @@ jobs:
MIRIFLAGS: "-Zmiri-disable-isolation"
run: |
cargo miri setup
cargo clean
# Ignore MIRI errors until we can get a clean run
cargo miri test || true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MIRI test on master fails to even start. For example: https://github.com/apache/arrow-datafusion/runs/7932578950?check_suite_focus=true

A libstd for Miri is now available in `/home/runner/.cache/miri/HOST`.
    Updating crates.io index
error: failed to select a version for the requirement `parquet = "^20.0.0"`
candidate versions found which didn't match: 15.0.0, 14.0.0, 13.0.0, ...
location searched: crates.io index
required by package `datafusion-common v11.0.0 (/home/runner/work/arrow-datafusion/arrow-datafusion/datafusion/common)`

cargo miri test

# Check answers are correct when hash values collide
hash-collisions:
Expand Down