Update headers for files copied from non ASF projects and update LICENSE #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei and
collado-mike
as code owners
jbonofre
requested review from
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
HonahX and
pingtimeout
as code owners
|
@justinmclean Can you please take a look, regarding your comment on Incubator general mailing list ? Thanks ! |
|
I will update spotless configuration to avoid to "force" ASF header (that's the reason why the header has been changed). |
dimas-b
reviewed
May 13, 2025
| @@ -37,7 +37,7 @@ if (!project.extra.has("duplicated-project-sources")) { | |||
| spotless { | |||
| kotlinGradle { | |||
| ktfmt().googleStyle() | |||
| licenseHeaderFile(rootProject.file("codestyle/copyright-header-java.txt"), "$") | |||
| // licenseHeaderFile(rootProject.file("codestyle/copyright-header-java.txt"), "$") | |||
There was a problem hiding this comment.
JB explained to me that this is to prevent spotlessApply from changing the headers back to ASF from dremio. We'll need to figure out how to get the plugin to allow for multiple headers.
There was a problem hiding this comment.
It's intentional: with that, spotless:apply "overwrites" all header with ASF header, which is wrong as we have to keep the original header in case of code copy.
RussellSpitzer
approved these changes
May 14, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ASF header in the files copied from non ASF projects (but ASLv2 licensed).
It also updates
LICENSEwith files not actually copied (but created in Apache Polaris).