Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from jsr305 to jspecify and error_prone_annotations #35133

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linghengqian
Copy link
Member

For #26041 .

Changes proposed in this pull request:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project shardingsphere-sql-federation-optimizer: Compilation failure: Compilation failure:
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[8,24] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 程序包 javax.annotation
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[8,24] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 程序包 javax.annotation
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[34,20] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushFilterIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[52,10] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushFilterIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[135,13] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushFilterIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[168,74] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushFilterIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[357,41] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushFilterIntoScanRule.Config.Builder
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[34,20] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushProjectIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[52,10] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushProjectIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[135,13] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushProjectIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[168,75] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushProjectIntoScanRule.Config
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[357,41] 找不到符号
[ERROR]   符号:   类 Nullable
[ERROR]   位置: 类 org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushProjectIntoScanRule.Config.Builder
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[269,60] 无法使用 type-use 批注 @org.jspecify.annotations.Nullable 来批注确定作用域结构  
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushFilterIntoScanRule.java:[270,57] 无法使用 type-use 批注 @org.jspecify.annotations.Nullable 来批注确定作用域结构  
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[269,60] 无法使用 type-use 批注 @org.jspecify.annotations.Nullable 来批注确定作用域结构 
[ERROR] /D:/TwinklingLiftWorks/git/public/shardingsphere/kernel/sql-federation/optimizer/target/generated-sources/annotations/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/ImmutablePushProjectIntoScanRule.java:[270,57] 无法使用 type-use 批注 @org.jspecify.annotations.Nullable 来批注确定作用域结构 

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • pom.xml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant